Re: Fix most -Wundef warnings

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Fix most -Wundef warnings
Date: 2019-10-13 19:56:59
Message-ID: 10954.1570996619@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> During the cleanup of the _MSC_VER versions (commit
> 38d8dce61fff09daae0edb6bcdd42b0c7f10ebcd), I found it useful to use
> -Wundef, but that resulted in a bunch of gratuitous warnings. Here is a
> patch to fix those. Most of these are just stylistic cleanups, but the
> change in pg_bswap.h is potentially useful to avoid misuse by
> third-party extensions.

Looks reasonable offhand.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2019-10-13 20:02:17 Re: d25ea01275 and partitionwise join
Previous Message Peter Eisentraut 2019-10-13 19:25:59 Fix most -Wundef warnings