Re: strange error reporting

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: strange error reporting
Date: 2021-01-21 22:03:09
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

I wrote:
> If I don't hear any other opinions, I'll change these messages to
> "connection to server at socket \"%s\" failed: "
> "connection to server at \"%s\" (%s), port %s failed: "

Done. Also, here is a patch to remove the redundant-seeming prefixes
from our reports of connection failures. My feeling that this is the
right thing was greatly increased when I noticed that psql, as well as
a few other programs, already did it like this. (I still favor
Alvaro's patch for the back branches, though.)

regards, tom lane

Attachment Content-Type Size
make-connection-failure-messages-less-redundant.patch text/x-diff 13.4 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message James Hilliard 2021-01-21 22:17:29 Re: [PATCH 1/1] Fix detection of pwritev support for OSX.
Previous Message Heikki Linnakangas 2021-01-21 21:54:04 Re: Avoiding smgrimmedsync() during nbtree index builds