Re: Allow to specify #columns in heap/index_form_tuple

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org, Anastasia Lubennikova <a(dot)lubennikova(at)postgrespro(dot)ru>
Subject: Re: Allow to specify #columns in heap/index_form_tuple
Date: 2017-03-31 17:44:52
Message-ID: 10913.1490982292@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Andres Freund <andres(at)anarazel(dot)de> writes:
> The covering indexes patch [1] really needs a version of
> heap_form_tuple/index_form_tuple that allows to specify the number of
> columns in the to-be generated tuple.

I was thinking about that this morning, and wondering why exactly it
would need such a thing. Certainly we're not going to store such a
truncated tuple in the index, so I assume that the purpose here is
just to pass around the tuple internally for some reason. What's wrong
with just generating the full tuple, perhaps with nulls for the extra
columns if you're concerned about memory space?

> Previously the faster expression
> evaluation stuff could also have benefited form the same for both
> forming and deforming tuples.

Um, I didn't notice anyplace where that would have helped, certainly
not on the "form tuple" side. Tuples that don't meet their own tupdesc
don't seem to have wide application to me.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-03-31 17:45:47 Re: Patch: Write Amplification Reduction Method (WARM)
Previous Message Anastasia Lubennikova 2017-03-31 17:40:59 Re: WIP: Covering + unique indexes.