Re: pg_dump bug fixing

From: Rod Taylor <pg(at)rbt(dot)ca>
To: Christopher Kings-Lynne <chriskl(at)familyhealth(dot)com(dot)au>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruno Wolff III <bruno(at)wolff(dot)to>, PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_dump bug fixing
Date: 2004-07-20 04:34:23
Message-ID: 1090298062.7056.13.camel@jester
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, 2004-07-19 at 21:20, Christopher Kings-Lynne wrote:
> > We already are to some extent, since pg_dump will dump its comment and
> > privileges, which it would not do for any other predefined object.
> > I think this is actually an implementation artifact rather than
> > something that was explicitly intended at the time, but since no one
> > has complained about it, it's probably a good thing ;-)
>
> Does that mean your in favour of dumping a DROP SCHEMA public; command
> if they have dropped their public schema? It's definitely not worth
> doing it for any other "system" object due to upwards compatibility of
> the dump files...

Please don't. It would be rather surprising to have stuff disappear from
a database while doing a restore -- especially if it's a CASCADE
operation.

Creating the public schema when needed and leaving it out by default is
preferable.

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2004-07-20 04:55:17 Re: Patch for pg_dump: Multiple -t options and new -T option
Previous Message Tom Lane 2004-07-20 04:14:29 Re: PITR COPY Failure (was Point in Time Recovery)