| From: | Simon Riggs <simon(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] Point in Time Recovery |
| Date: | 2004-07-19 06:39:03 |
| Message-ID: | 1090219142.17493.22023.camel@stromboli |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-admin pgsql-hackers pgsql-patches |
On Mon, 2004-07-19 at 04:13, Tom Lane wrote:
> Simon Riggs <simon(at)2ndquadrant(dot)com> writes:
> > When archiver starts the FIRST thing it does is run a test to confirm
> > that the command string works, so setting archive_command to '' would
> > simply generate an error.
>
> No, it would do no such thing; the test cannot really tell anything more
> than whether system("foo") returns zero ... and at least on my machine,
> system("") returns zero. It certainly does not prove that any data went
> to anyplace safe.
>
> I diked that test out of the committed patch because I felt it cluttered
> the archive area without actually proving anything of interest. We can
> revisit the point if you like.
>
If the test doesn't guarantee success, then it needs to go....
Thanks for removing it.
Best Regards, Simon Riggs
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2004-07-19 07:35:05 | Re: [HACKERS] Point in Time Recovery |
| Previous Message | Stephan Szabo | 2004-07-19 04:56:33 | Re: inheritance question |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2004-07-19 07:35:05 | Re: [HACKERS] Point in Time Recovery |
| Previous Message | Tom Lane | 2004-07-19 05:10:33 | Re: CVS compile failure |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2004-07-19 07:35:05 | Re: [HACKERS] Point in Time Recovery |
| Previous Message | Tom Lane | 2004-07-19 04:54:13 | Re: [HACKERS] Point in Time Recovery |