| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
| Cc: | pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Allowing ALTER TYPE to change storage strategy |
| Date: | 2020-03-06 17:20:43 |
| Message-ID: | 10877.1583515243@sss.pgh.pa.us |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> writes:
> On Thu, Mar 05, 2020 at 05:46:44PM -0500, Tom Lane wrote:
>> For ease of review I just added the new TCFLAGS value out of
>> sequence, but I'd be inclined to renumber the bits back into
>> sequence before committing.
> LGTM. If I had to nitpick, I'd say that the example in docs should be
> ALTER TYPE mytype SET (
> SEND = mytypesend,
> RECEIVE = mytyperecv
> );
> i.e. with uppercase SEND/RECEIVE, because that's how we spell it in
> other examples in CREATE TYPE etc.
OK, pushed with those changes and some other docs-polishing.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-03-06 17:23:58 | Re: Allowing ALTER TYPE to change storage strategy |
| Previous Message | Julien Rouhaud | 2020-03-06 17:14:37 | Re: WAL usage calculation patch |