Re: vcbuild bison check

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-hackers(at)postgresql(dot)org, "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: vcbuild bison check
Date: 2006-10-03 20:40:18
Message-ID: 10858.1159908018@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
>>> Attached patch adds a version check for bison when running the vc++
>>> build.
>>
>> Shouldn't it be looking for 2.1 as well?

> 2.1 is the broken one.

Exactly. So we should reject it.

> It seemd it was fixed in 2.2, but 2.2 isn't
> realeased for win32 from what I cna tell.

What's that got to do with rejecting 2.1?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2006-10-03 20:44:28 Re: [HACKERS] Bad bug in fopen() wrapper code
Previous Message Tom Lane 2006-10-03 20:36:13 Re: MSVC build broken (again)

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2006-10-03 20:44:28 Re: [HACKERS] Bad bug in fopen() wrapper code
Previous Message Tom Lane 2006-10-03 20:36:13 Re: MSVC build broken (again)