Re: Assertion failure due to ColumnRefStar

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
Cc: NikhilS <nikkhils(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Assertion failure due to ColumnRefStar
Date: 2007-09-27 16:51:34
Message-ID: 10795.1190911894@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

I wrote:
> The problem here is that in the output of the grammar, * is represented
> exactly the same as "*" would be ... I suppose this representation was
> chosen back in the day before we had full support for quoted column
> names.

I took a brief look at this. Changing that representation seems like
it'd be a fairly simple exercise, but I don't want to get into doing it
before 8.3 beta, and it'd be too invasive for a back-patch anyway. What
I propose for the moment is to replace the Assert with a plain elog:

if (!targetlist)
elog(ERROR, "invalid use of *");

Thoughts?

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrew Dunstan 2007-09-27 16:53:50 Re: Getting to 8.3 beta1
Previous Message Simon Riggs 2007-09-27 16:47:21 Re: Getting to 8.3 beta1