| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com> |
| Cc: | Kohei Kaigai <Kohei(dot)Kaigai(at)EMEA(dot)NEC(dot)COM>, Kohei KaiGai <kaigai(at)kaigai(dot)gr(dot)jp>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: force_not_null option support for file_fdw |
| Date: | 2011-09-16 20:40:06 |
| Message-ID: | 10793.1316205606@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com> writes:
> (2011/09/09 0:47), Kohei Kaigai wrote:
>> makeString() does not copy the supplied string itself, so it is not preferable to reference
>> NameStr(attr->attname) across ReleaseSysCache().
> Oops, fixed.
> [ I should check some of my projects for this issue... ]
I've committed this with some mostly-cosmetic revisions, notably
* use defGetBoolean, since this ought to be a plain boolean option
rather than having its own private idea of which spellings are accepted.
* get rid of the ORDER BY altogether in the regression test case ---
it seems a lot safer to assume that COPY will read the data in the
presented order than that text will be sorted in any particular way.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2011-09-16 21:02:38 | Re: Improve lseek scalability v3 |
| Previous Message | Benjamin LaHaise | 2011-09-16 20:08:17 | Re: Improve lseek scalability v3 |