| From: | Alexander Lakhin <exclusion(at)gmail(dot)com> |
|---|---|
| To: | Alexander Korotkov <aekorotkov(at)gmail(dot)com>, Andrei Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> |
| Cc: | "Gregory Stark (as CFM)" <stark(dot)cfm(at)gmail(dot)com>, Michał Kłeczek <michal(at)kleczek(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Removing unneeded self joins |
| Date: | 2023-10-23 11:00:00 |
| Message-ID: | 107682e0-137a-d0fb-2733-7fc6e9562690@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Alexander,
23.10.2023 12:47, Alexander Korotkov wrote:
> I think this patch makes substantial improvement to query planning.
> It has received plenty of reviews. The code is currently in quite
> good shape. I didn't manage to find the cases when this optimization
> causes significant overhead to planning time. Even if such cases will
> be spotted there is a GUC option to disable this feature. So, I'll
> push this if there are no objections.
On a quick glance, I've noticed following typos/inconsistencies in the
patch, which maybe worth fixing:
s/cadidates/candidates/
s/uniquiness/uniqueness/
s/selfjoin/self-join/
s/seperate/separate/
Also, shouldn't the reference "see generate_implied_equalities" be
"see generate_implied_equalities_for_column"?
Best regards,
Alexander
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alexander Korotkov | 2023-10-23 11:29:15 | Re: Removing unneeded self joins |
| Previous Message | Pavel Luzanov | 2023-10-23 10:17:42 | Re: WIP: new system catalog pg_wait_event |