Re: remove bits* types

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Álvaro Herrera <alvherre(at)kurilemu(dot)de>
Cc: Nathan Bossart <nathandbossart(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: remove bits* types
Date: 2026-03-18 22:41:20
Message-ID: 1074366.1773873680@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

=?utf-8?Q?=C3=81lvaro?= Herrera <alvherre(at)kurilemu(dot)de> writes:
> Shrug. As I said in the other thread, it seems mildly useful to
> distinguish the cases where stuff is there solely to be treated as a
> mask of independent bits instead of something you do arithmetic with.

I could get behind that if we were declaring bitmask variables using
bitsNN more or less consistently, but if we do that at all it's a
minority usage. I didn't even realize there was any such convention.
A lot of the places Nathan is changing don't look like they are
following such a convention anyway.

In short: maybe we don't want to go in the direction Nathan suggests,
but if we keep these types we should make an effort to use them
more consistently, so there's work to be done in that direction too.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2026-03-18 22:43:54 Re: pg_plan_advice
Previous Message Tomas Vondra 2026-03-18 22:41:13 Re: EXPLAIN: showing ReadStream / prefetch stats