| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> |
| Cc: | Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Fuzzy substring searching with the pg_trgm extension |
| Date: | 2016-01-11 23:57:51 |
| Message-ID: | 10712.1452556671@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Alvaro Herrera <alvherre(at)2ndquadrant(dot)com> writes:
>> + <entry><function>show_substring_limit()</function><indexterm><primary>show_substring_limit</primary></indexterm></entry>
>> + <entry><function>set_substring_limit(real)</function><indexterm><primary>set_substring_limit</primary></indexterm></entry>
> I don't quite understand why aren't we using a custom GUC variable here.
Presumably this is following the existing set_limit() precedent
in pg_trgm. But I tend to agree that that's a crummy precedent
and we should not extend it.
Let's invent a custom GUC for the regular limit, mark show_limit()
and set_limit as deprecated, and then make just a custom GUC for
this other limit.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2016-01-12 00:16:42 | Re: Patch: fix lock contention for HASHHDR.mutex |
| Previous Message | Alvaro Herrera | 2016-01-11 23:50:46 | Re: [PROPOSAL] Client Log Output Filtering |