Re: Autogenerate some wait events code and documentation

From: "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Autogenerate some wait events code and documentation
Date: 2023-05-15 16:45:23
Message-ID: 106e8d0a-0820-687a-7da5-3143e1f5b05b@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 5/6/23 4:37 AM, Michael Paquier wrote:
> On Sat, May 06, 2023 at 11:23:17AM +0900, Michael Paquier wrote:
>>> I'll look at v7 when the v17 branch opens and propose the separate patch
>>> mentioned above at that time too.
>>
>> Thanks, again.
>
> By the way, while browsing through the patch, I have noticed two
> things:
> - The ordering of the items for Lock and LWLock is incorrect.

Oh right, fixed in V8 attached (moved the sort on the third column
instead of the second which has always the same content "WAIT_EVENT_DOCONLY"
for Lock and LWLock).

> - We are missing some of the LWLock entries, like CommitTsBuffer,
> XactBuffer or WALInsert, as of all the entries in
> BuiltinTrancheNames.
>

Yeah, my bad. Fixed in V8 attached.

> My apologies for not noticing that earlier. This exists in v6 as much
> as v7.

No problem at all and thanks for the call out!

Regards,

--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com

Attachment Content-Type Size
v8-0001-Generating-wait_event_types.h-pgstat_wait_event.c.patch text/plain 127.3 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2023-05-15 17:55:56 Re: Large files for relations
Previous Message MARK CALLAGHAN 2023-05-15 16:43:17 Re: Large files for relations