Re: BUG #14890: Error grouping by same column twice using FDW

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: sean(dot)johnston(at)edgeintelligence(dot)com
Cc: pgsql-bugs(at)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com>, Jeevan Chalke <jeevan(dot)chalke(at)enterprisedb(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)enterprisedb(dot)com>
Subject: Re: BUG #14890: Error grouping by same column twice using FDW
Date: 2017-11-07 22:29:41
Message-ID: 10660.1510093781@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

sean(dot)johnston(at)edgeintelligence(dot)com writes:
> select col1, col1 from loop_tbl group by 1, 2;
> psql:t.sql:7: ERROR: targetlist item has multiple sortgroupref labels

This is the fault of commit 7012b132d ("Push down aggregates to remote
servers"), which imagined that postgres_fdw can use
apply_pathtarget_labeling_to_tlist() for situations well beyond that
function's limited abilities. I kinda suspect that foreign_grouping_ok()
has got more bugs than this with complicated sortgroupref situations, too;
its willingness to scribble on the sortgrouprefs doesn't look like a great
idea to me.

regards, tom lane

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Michael Paquier 2017-11-08 01:37:57 Re: Fails to work on live images due to fsync() on pg_commit_ts before doing any write there
Previous Message Alexander Korotkov 2017-11-07 16:24:27 Re: Fwd: pg_trgm word_similarity inconsistencies or bug