WIP: unique hash indexes

From: Neil Conway <neilc(at)samurai(dot)com>
To: PostgreSQL Patches <pgsql-patches(at)postgresql(dot)org>
Subject: WIP: unique hash indexes
Date: 2003-09-20 07:51:07
Message-ID: 1064044267.4626.350.camel@tokyo
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-patches

Attached is a patch that implements unique hash indexes. Regression
tests and docs have been updated (with the exception of

This patches implements an improved version of the concurrency changes I
outlined on -hackers a couple days ago: the separate lock for
"right-of-insertion" into a bucket chain has been replaced by making use
of existing lmgr lockmodes to get the behavior we need.

I also took the opportunity to refactor the hash index code in a couple
places by moving duplicated code into separate functions, fixed some
typos in the README file, etc.

I've tested this a little bit (it survives 100,000 single-user pgbench
transactions, and 10 concurrent clients doing 1000 transactions each),
but I need to do more testing in the future.

As far as I know, the unique hash index code is functionally complete,
but don't add this to the patch queue (it is obviously for 7.5, anyway),
since I'm about to get started on some related hash index work, for
which I'll submit a mega-patch containing everything. I just posted this
here so that anyone who's interested can take a look at it -- comments
are welcome.

Thanks to Tom Lane, who was very helpful when I asked him code
questions, including suggesting the improved concurrency design I
mentioned above.



Attachment Content-Type Size
index_cleanup-17.patch text/x-patch 77.3 KB


Browse pgsql-patches by date

  From Date Subject
Next Message Manfred Spraul 2003-09-20 10:34:00 Re: semtimedop instead of setitimer/semop/setitimer
Previous Message Hiroshi Inoue 2003-09-20 03:04:40 Re: pgsql-server/src/backend catalog/index.c comma ...