028_pitr_timelines.pl might fail when cp interrupted and backup includes required segment

From: Филиппов Степан <stepan(dot)filippov(at)yandex(dot)ru>
To: "x4mmm(at)yandex-team(dot)ru" <x4mmm(at)yandex-team(dot)ru>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: 028_pitr_timelines.pl might fail when cp interrupted and backup includes required segment
Date: 2026-09-03 04:54:42
Message-ID: 1062171788411186@mail.yandex.ru
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

<div>+ pgsql-hackers@</div><div> </div><div> </div><div> </div><div>----------------</div><div>31.08.2026, 16:30, "Andrey Borodin" &lt;x4mmm(at)yandex-team(dot)ru&gt;:</div><blockquote><p>In v2, both platforms use the test process PID and the node port. The<br />PID distinguishes parallel tests, and the port distinguishes nodes in<br />one test. There is only one archiver per node, so retries can safely<br />reuse the same temporary path.<br /><br />I also documented that archive commands with concurrent readers should<br />publish complete files atomically, and warned that the simple cp example<br />does not. I did not present the helper's mv -f as a production recipe,<br />because that would contradict the existing requirement not to overwrite<br />a different pre-existing segment.</p></blockquote><div> </div><div><div style="background-color:rgb( 255 , 255 , 255 );color:rgb( 26 , 26 , 26 );font-family:'ys text' , 'arial' , sans-serif;font-size:16px;font-style:normal;font-weight:400;text-align:start;text-decoration-color:initial;text-decoration-style:initial;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px">Thank you for your work. Checked code and documentation.<br />Now this patch looks great to me.<br /><br />As for frequency of failures, I believe that renaming will be more reliable.<br />As long as we expect it to be atomic on all systems.<br /> </div><div style="background-color:rgb( 255 , 255 , 255 );color:rgb( 26 , 26 , 26 );font-family:'ys text' , 'arial' , sans-serif;font-size:16px;font-style:normal;font-weight:400;text-align:start;text-decoration-color:initial;text-decoration-style:initial;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px"><div>Best regards, Stepan Filippov.</div></div></div>

Attachment Content-Type Size
unknown_filename text/html 1.7 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message shveta malik 2026-09-03 04:57:43 Re: Support EXCEPT for TABLES IN SCHEMA publications
Previous Message Antonin Houska 2026-09-03 04:42:06 Re: REPACK (ANALYZE) within transaction block segfaults