| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Álvaro Herrera <alvherre(at)kurilemu(dot)de>, Peter Eisentraut <peter(at)eisentraut(dot)org>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Cleanup shadows variable warnings, round 1 |
| Date: | 2025-12-03 23:04:02 |
| Message-ID: | 105E05F5-4BF1-459F-8012-94D90C75BE0F@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Dec 4, 2025, at 05:00, Peter Smith <smithpb2250(at)gmail(dot)com> wrote:
>
> On Thu, Dec 4, 2025 at 1:36 AM Álvaro Herrera <alvherre(at)kurilemu(dot)de> wrote:
>>
>> On 2025-Dec-03, Chao Li wrote:
>>
>>> Unfortunately that doesn’t work for my compiler (clang on MacOS),
>>> that’s why I renamed “I" to “u”.
>>
>> I think you're missing his point. He's suggesting to change not only
>> this variable, but also the other uses of "i" in this function.
>>
>
> Exactly. I should have posted the larger diff, as you did. Thanks for
> clarifying.
>
Sorry for misunderstanding you. I guess I read your message too quickly yesterday. Will fix it in v4.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Melanie Plageman | 2025-12-03 23:07:38 | Re: eliminate xl_heap_visible to reduce WAL (and eventually set VM on-access) |
| Previous Message | Masahiko Sawada | 2025-12-03 22:55:44 | Re: [PATCH] Add error hints for invalid COPY options |