Re: pgsql: Default to hidden visibility for extension libraries where possi

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Cc: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Default to hidden visibility for extension libraries where possi
Date: 2022-07-19 13:45:52
Message-ID: 1057666.1658238352@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> On 2022-Jul-19, Pavel Stehule wrote:
>> Unfortunately, this commit definitely breaks plpgsql_check. Can the
>> following routines be visible?

> Do you just need to send a patch to add an exports.txt file to
> src/pl/plpgsql/src/ for these functions?

The precedent of plpython says that PGDLLEXPORT markers are sufficient.
But yeah, we need a list of exactly which functions need to be
re-exposed. I imagine pldebugger has its own needs.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Alvaro Herrera 2022-07-19 14:28:07 Re: pgsql: Default to hidden visibility for extension libraries where possi
Previous Message Alvaro Herrera 2022-07-19 13:18:01 Re: pgsql: Default to hidden visibility for extension libraries where possi

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2022-07-19 13:52:18 Re: Transparent column encryption
Previous Message Tom Lane 2022-07-19 13:36:48 Re: Windows now has fdatasync()