| From: | amul sul <sul_amul(at)yahoo(dot)co(dot)in> |
|---|---|
| To: | Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Alex Ignatov <a(dot)ignatov(at)postgrespro(dot)ru>, Bruce Momjian <bruce(at)momjian(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Bug in to_timestamp(). |
| Date: | 2016-08-25 09:10:29 |
| Message-ID: | 1054231194.17565594.1472116229825.JavaMail.yahoo@mail.yahoo.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Thursday, August 25, 2016 1:56 PM, Artur Zakirov <a(dot)zakirov(at)postgrespro(dot)ru> wrote:
>> #2. Warning at compilation;
>>
>> formatting.c: In function ‘do_to_timestamp’:
>> formatting.c:3049:37: warning: ‘prev_type’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>> if (prev_type == NODE_TYPE_SPACE || prev_type == NODE_TYPE_SEPARATOR)
>> ^
>> formatting.c:2988:5: note: ‘prev_type’ was declared here
>> prev_type;
>> ^
>>
>> You can avoid this by assigning zero (or introduce NODE_TYPE_INVAL ) to prev_type at following line:
>>
>> 256 + prev_type;
>
>
>You are right. I assigned to prev_type NODE_TYPE_SPACE to be able to
>execute such query:
>
>
>SELECT to_timestamp('---2000----JUN', 'YYYY MON');
>
>
>Will be it a proper behaviour?
Looks good to me, no one will complain if something working on PG but not on Oracle.
Thanks & Regards,
Amul Sul
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuki Kadomoto | 2016-08-25 09:45:30 | Checksum error and VACUUM FULL |
| Previous Message | Artur Zakirov | 2016-08-25 08:25:23 | Re: Bug in to_timestamp(). |