| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com> |
| Cc: | "Pg Hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Cleanup of PLpgSQL_recfield |
| Date: | 2008-11-05 00:08:28 |
| Message-ID: | 1050.1225843708@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
"Jonah H. Harris" <jonah(dot)harris(at)gmail(dot)com> writes:
> On Tue, Nov 4, 2008 at 3:57 PM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> I am not real sure why the code is inconsistent about spelling the
>> second field's name differently in some of the structs, but it seems
>> like a bad idea --- as you've demonstrated, it invites confusion.
>> What would probably be better is a patch to rename exprno, rfno, etc
>> to all be called dno to make this connection more obvious.
> Attached. Passed regressions and basic testing.
Looks good, applied.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Guillaume Lelarge | 2008-11-05 00:10:22 | Re: Patch for ALTER DATABASE WITH TABLESPACE |
| Previous Message | Emmanuel Cecchet | 2008-11-04 23:50:24 | Re: Transactions and temp tables |