| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: COPY FROM WITH HEADER skips a tuple every 4 billion tuples |
| Date: | 2018-05-22 16:44:55 |
| Message-ID: | 10484.1527007495@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Andres Freund <andres(at)anarazel(dot)de> writes:
> On 2018-05-22 11:55:26 -0400, Tom Lane wrote:
>> Hm, so why is the correct rowcount returned --- are we running
>> a separate counter for that purpose, and if so why?
> Yes, it's a local counter in CopyFrom/CopyTo. It's probably not
> entirely trivial to unify the two. The batching etc makes us modify
> cur_lineno in a bit weird ways at times.
OK, we'll just do it like David suggests then. I haven't checked the
patch in detail yet, but it seemed generally sane if we're just going
to widen the duplicate counter.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2018-05-22 16:47:40 | Re: Postgres, fsync, and OSs (specifically linux) |
| Previous Message | Andrew Dunstan | 2018-05-22 16:18:04 | Re: plperl fails with perl 5.28 |