Re: code cleanup for tz

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: code cleanup for tz
Date: 2005-06-20 13:22:42
Message-ID: 1048.1119273762@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> This patch makes various cosmetic improvements to the timezone code:
> remove the use of the register qualifier, make some function declaration
> syntax a bit more consistent, etc.

I think mostly what you are doing here is causing code drift from the
upstream "zic" code. I don't think that's a very good idea, since we
do need to be able to track and apply bug fixes from them from time
to time ...

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Dave Page 2005-06-20 15:27:55 Re: Default database patch
Previous Message Dave Page 2005-06-20 12:07:17 Default database patch