Re: BUG #6672: Memory leaks in dumputils.c

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Josh Kupershmidt <schmiddy(at)gmail(dot)com>
Cc: zaks(dot)anna(at)gmail(dot)com, pgsql-bugs(at)postgresql(dot)org
Subject: Re: BUG #6672: Memory leaks in dumputils.c
Date: 2012-06-03 15:54:29
Message-ID: 10452.1338738869@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs

Josh Kupershmidt <schmiddy(at)gmail(dot)com> writes:
>> zaks(dot)anna(at)gmail(dot)com writes:
>>> There are two memory leaks in dumputils (v9.2.0beta1):

> ... Both of these errors seem academic, since the callers
> of buildACLCommands() will bail out with exit_horribly() or
> exit_nicely() if it returns false. But IMO it's worth fixing anyway,
> to keep the compilers happy or in case of future code calling
> buildACLCommands() or parseAclItem().

Agreed.

> Attached is a patch to hopefully fix those two errors.

Applied, thanks.

regards, tom lane

In response to

Browse pgsql-bugs by date

  From Date Subject
Next Message Shigeru Hanada 2012-06-04 10:41:47 control character check in JSON type seems broken
Previous Message shinsetsusan 2012-06-03 09:56:45 BUG #6674: functon aggregat