Re: Remove confusing commented-defaullts from postgresql.conf

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Greg Sabino Mullane <greg(at)turnstep(dot)com>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Remove confusing commented-defaullts from postgresql.conf
Date: 2004-07-13 03:12:29
Message-ID: 10371.1089688349@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> Uh, it is my understanding that all lines can't be uncommented. Some of
> the lines have defaults that are computed, like fsync_method.

Yes, fsync_method shouldn't be uncommented unless you're prepared to put
in the same default value presently computed in xlog.c. (Now that
initdb is in C, it might not be unreasonable to move the #ifdef hacking
that's in xlog.c over to initdb...)

Also you'd need to make some other adjustments in initdb; IIRC it does
sed-like substitutions that will break if the input is not just so.
I don't recall at the moment but there may be some things of the same
ilk done during "make install". And check the documentation to see if
any discussion needs updated.

> Anyway, we are too busy to consider this for 7.5 unless someone wants to
> research all these issues.

No reason Greg can't do it if he wants to ... but the .sample file
itself is certainly not all that needs changing.

regards, tom lane

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Greg Sabino Mullane 2004-07-13 11:45:20 Re: Remove confusing commented-defaullts from postgresql.conf
Previous Message Bruce Momjian 2004-07-13 03:00:49 pgsql-server: Change pg_dump to use ALTER OWNER commands instead of SET

Browse pgsql-patches by date

  From Date Subject
Next Message Simon Riggs 2004-07-13 11:09:11 Re: PITR Archive Recovery plus WIP PITR
Previous Message Gavin Sherry 2004-07-13 03:06:16 Re: Include tablespace information in psql \d footers