| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> |
| Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-committers <pgsql-committers(at)postgresql(dot)org> |
| Subject: | Re: pgsql: pageinspect: Try to fix some bugs in previous commit. |
| Date: | 2017-02-03 14:43:33 |
| Message-ID: | 10350.1486133013@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> writes:
> I have gone through all the of the SQL declarations and it seems
> hash_metapage_info(...,OUT procid int4,..) is not consistent. procid
> is unsigned int, so isn't it better to use the corresponding datatype
> as int8 in SQL function hash_metapage_info then use Int64GetDatum?
Isn't procid an OID? I'd use OID or maybe even regprocedure on
the SQL side.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-02-03 14:49:27 | Re: pgsql: pageinspect: Try to fix some bugs in previous commit. |
| Previous Message | Ashutosh Sharma | 2017-02-03 12:41:14 | Re: pgsql: pageinspect: Try to fix some bugs in previous commit. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2017-02-03 14:49:27 | Re: pgsql: pageinspect: Try to fix some bugs in previous commit. |
| Previous Message | Ashutosh Bapat | 2017-02-03 14:26:41 | Re: patch: optimize information_schema.constraint_column_usage |