Re: Reduce the size of PageFreeSpaceInfo on 64bit platform

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: Reduce the size of PageFreeSpaceInfo on 64bit platform
Date: 2007-08-10 04:45:32
Message-ID: 10318.1186721132@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> writes:
> - Size avail; /* space available on this page */
> + uint32 avail; /* space available on this page */

This declaration ties into a boatload of others, eg, just about every
use of Size in freespace.h. I'm unconvinced that we need to change it,
but if we do, the patch needs to be a lot bigger.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Brendan Jurd 2007-08-10 16:53:11 Re: [HACKERS] Function structure in formatting.c
Previous Message ITAGAKI Takahiro 2007-08-10 01:32:35 Reduce the size of PageFreeSpaceInfo on 64bit platform