Re: [SQL] LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1?

From: Rod Taylor <rbt(at)zort(dot)ca>
To: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>, Larry Rosenman <ler(at)lerctr(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [SQL] LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1?
Date: 2002-08-28 14:28:51
Message-ID: 1030544932.83275.58.camel@jester
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-sql

On Wed, 2002-08-28 at 10:24, Robert Treat wrote:
> On Wed, 2002-08-28 at 10:11, Tom Lane wrote:
> > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > Larry Rosenman wrote:
> > >> Why? If both old and new are acceptable, why not document it?
> > >> (Just curious, I'm not wedded to it).
> >
> > > Well, showing both versions adds confusion for no good reason,
> >
> > Yes, particularly considering that LIMIT ... FOR UPDATE corresponds
> > to the implementation behavior (LIMIT acts before FOR UPDATE) while
> > FOR UPDATE ... LIMIT does not.
> >
> > I concur with documenting only the preferred form (though there should
> > be a note in gram.y explaining that we're supporting the old syntax
> > for backward compatibility).
> >
>
> Doesn't the need for a note explaining that we're supporting the old
> syntax say to you that the documentation also needs to say we support
> the old syntax? I can see the bug reports now saying "this is clearly
> not what it says in the docs"...

Yes, both should be documented. But mark the non-preferred version as
depreciated and disappearing soon (whether it does or not is another
story) but discourage people from using it.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Marc G. Fournier 2002-08-28 14:35:31 Re: tell Bugtraq about 7.2.2
Previous Message Bruce Momjian 2002-08-28 14:26:53 Re: [SQL] LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1?

Browse pgsql-sql by date

  From Date Subject
Next Message Ligia Pimentel 2002-08-28 14:38:41 Re: Problems with version 7.1, could they be fixed in 7.2?
Previous Message Bruce Momjian 2002-08-28 14:26:53 Re: [SQL] LIMIT 1 FOR UPDATE or FOR UPDATE LIMIT 1?