Re: fix type of infomask parameter in static inline functions

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org, peter(at)eisentraut(dot)org
Subject: Re: fix type of infomask parameter in static inline functions
Date: 2025-10-22 21:16:54
Message-ID: 1030409.1761167814@sss.pgh.pa.us
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Nathan Bossart <nathandbossart(at)gmail(dot)com> writes:
> I noticed that a couple of the functions added by commit 34694ec use
> "int16" instead of "uint16" for the infomask parameter. I don't think
> there are any live bugs here, but IMHO we should at least fix this for v19
> to help prevent future problems.

> Assuming there is agreement on this change, any thoughts on back-patching?

+1 for changing, but -1 for back-patching. Unless you're itching
for reasons to update .abi-compliance-history. But if there's no
live bug, that seems like make-work.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Masahiko Sawada 2025-10-22 21:23:03 Re: POC: enable logical decoding when wal_level = 'replica' without a server restart
Previous Message Alexander Lakhin 2025-10-22 21:00:01 Re: Instability of phycodorus in pg_upgrade tests with JIT