|From:||Nikolay Shaplov <dhyan(at)nataraj(dot)su>|
|To:||Greg Stark <stark(at)mit(dot)edu>|
|Cc:||PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: [PATCH] minor reloption regression tests improvement|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
В письме от понедельник, 7 марта 2022 г. 20:04:49 MSK пользователь Greg Stark
> I don't think this is worth spending time adding tests for. I get what
> you're saying that this is at least semi-intentional behaviour and
> desirable behaviour so it should have tests ensuring that it continues
> to work. But it's not documented behaviour and the test is basically
> testing that the implementation is this specific implementation.
> I don't think the test is really a bad idea but neither is it really
> very useful and I think it's not worth having people spend time
> reviewing and discussing. I'm leaning to saying this patch is
This is a regression test. To test if behaviour brocken or not.
Actually I came to the idea of the test when I wrote my big reloption patch.
I've broken this behaviour by mistake and did not notice it as it have not
been properly tested. So I decided it would be goo to add test to it before
adding and big patches.
Nikolay Shaplov aka Nataraj
Fuzzing Engineer at Postgres Professional
Matrix IM: @dhyan:nataraj.su
|Next Message||Robert Haas||2022-03-07 17:51:22||Re: role self-revocation|
|Previous Message||Zhihong Yu||2022-03-07 17:42:26||refreshing query id for pg_stat_statements based on comment in sql|