Skip site navigation (1) Skip section navigation (2)

Re: Idea for minor tstore optimization

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Idea for minor tstore optimization
Date: 2008-02-27 22:48:53
Message-ID: (view raw, whole thread or download thread mbox)
Lists: pgsql-hackers
Neil Conway <neilc(at)samurai(dot)com> writes:
> I notice that several of the call sites of tuplestore_puttuple() start
> with arrays of datums and nulls, call heap_form_tuple(), and then switch
> into the tstore's context and call tuplestore_puttuple(), which
> deep-copies the HeapTuple into the tstore. ISTM it would be faster and
> simpler to provide a tuplestore_putvalues(), which just takes the datum
> + nulls arrays and avoids the additional copy.

Seems reasonable.  Check whether tuplesort should offer the same, while
you are at it.

			regards, tom lane

In response to


pgsql-hackers by date

Next:From: Dawid KuroczkoDate: 2008-02-27 23:15:00
Subject: UUID data format 4x-4x-4x-4x-4x-4x-4x-4x
Previous:From: Simon RiggsDate: 2008-02-27 22:45:38
Subject: Snapshot Reuse

Privacy Policy | About PostgreSQL
Copyright © 1996-2017 The PostgreSQL Global Development Group