Re: psql: default base and password reading

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>, Bradley McLean <brad(at)bradm(dot)net>, Adam Osuchowski <adwol(at)polsl(dot)gliwice(dot)pl>
Subject: Re: psql: default base and password reading
Date: 2001-10-13 15:47:17
Message-ID: 10217.1002988037@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> The patch uses /dev/tty if it can open it, and stdin if it can't. It
> does not have a psql flag to force stdin because there is little reason
> to read a password from stdin in any reasonable usage.

If we are reading the password from /dev/tty not stdin, then IMHO the
prompt for the password should be sent to /dev/tty not stderr.

> In fact, I wonder if we should just fail if we need to prompt for a
> password and can't open /dev/tty. The function is simple_prompt() and
> if we can't open /dev/tty, maybe we should just assume the user typed
> nothing.

Would be okay with me ...

regards, tom lane

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2001-10-13 15:53:22 Re: psql: default base and password reading
Previous Message Greg Sabino Mullane 2001-10-13 15:43:55 Re: Showing index details with \d on psql