Re: Patch to add a primary key using an existing index

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Steve Singer <ssinger_pg(at)sympatico(dot)ca>
Cc: Gurjeet Singh <singh(dot)gurjeet(at)gmail(dot)com>, PGSQL Hackers <pgsql-hackers(at)postgresql(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Robert Haas <robertmhaas(at)gmail(dot)com>, r t <pgsql(at)xzilla(dot)net>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>
Subject: Re: Patch to add a primary key using an existing index
Date: 2011-01-24 18:00:22
Message-ID: 10207.1295892022@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Steve Singer <ssinger_pg(at)sympatico(dot)ca> writes:
> src/backend/parser/parse_utilcmd.c: 1452
> Your calling strdup on the attribute name. I don't have a good enough
> grasp on the code to be able to trace this through to where the memory
> gets free'd. Does it get freed? Should/could this be a call to pstrdup

strdup() is pretty much automatically wrong in the parser, not to
mention most of the rest of the backend. pstrdup is likely what was
meant. If that's the only issue then I don't see any need to wait on
the author, so will take this one.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Magnus Hagander 2011-01-24 18:22:20 Re: Allowing multiple concurrent base backups
Previous Message Tom Lane 2011-01-24 17:26:24 Re: wildcard search support for pg_trgm