Re: [pgsql-hackers-win32] Win32 & NLS

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: "Magnus Hagander" <mha(at)sollentuna(dot)net>
Cc: "Peter Eisentraut" <peter_e(at)gmx(dot)net>, "pgsql-patches" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [pgsql-hackers-win32] Win32 & NLS
Date: 2004-10-17 19:31:06
Message-ID: 10159.1098041466@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> Test program attached, results below. It returns NULL for
> whatever I try with LC_MESSAGES.

It looks like LC_MESSAGES just plain does not work on Windows. I did
some googling and found some pages suggesting this, for instance

http://msdn.microsoft.com/library/default.asp?url=/library/en-us/vclib/html/_crt_setlocale.2c_._wsetlocale.asp

The patch you suggest looks remarkably ugly; in particular it is
generally unsafe to pass a local variable to putenv. Perhaps that
does not matter on Windows but I wonder whether the putenv part couldn't
just be dropped. And why bother with ZeroMemory?

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Andrew Dunstan 2004-10-17 19:35:10 strange result from contrib/seg regression on windows
Previous Message Andrew Dunstan 2004-10-17 19:10:52 windows progname / regression fixes