| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Lætitia Avrot <laetitia(dot)avrot(at)gmail(dot)com> |
| Subject: | Re: pgsql: Add support for hyperbolic functions, as well as log10(). |
| Date: | 2019-03-14 02:39:03 |
| Message-ID: | 1015.1552531143@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> On Wed, Mar 13, 2019 at 8:49 PM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> Meh. As I said before, we're not in the business of improving on what
>> libm does --- if someone has a beef with the results, they need to take
>> it to their platform's libm maintainer, not us. The point of testing
>> this at all is just to ensure that we've wired up the SQL functions
>> to the library functions correctly.
> Pretty sure we don't even need a test for that. asinh() isn't going
> to call creat() by mistake.
No, but that's not the hazard. I have a very fresh-in-mind example:
at one point while tweaking Laetitia's patch, I'd accidentally changed
datanh so that it called tanh not atanh. The previous set of tests did
not reveal that :-(
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-03-14 02:40:18 | Re: pgsql: Add support for hyperbolic functions, as well as log10(). |
| Previous Message | Robert Haas | 2019-03-14 02:22:44 | Re: pgsql: Add support for hyperbolic functions, as well as log10(). |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2019-03-14 02:39:37 | Re: Timeout parameters |
| Previous Message | Amit Langote | 2019-03-14 02:30:12 | Re: Fix handling of unlogged tables in FOR ALL TABLES publications |