|From:||Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>|
|To:||David Steele <david(at)pgmasters(dot)net>|
|Cc:||Robert Haas <robertmhaas(at)gmail(dot)com>, Pierre-Emmanuel André <pea(at)openbsd(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Marisa Emerson <mje(at)insec(dot)sh>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>|
|Subject:||Re: Proposal: BSD Authentication support|
|Views:||Raw Message | Whole Thread | Download mbox | Resend email|
David Steele <david(at)pgmasters(dot)net> writes:
> On 4/8/16 11:20 AM, Robert Haas wrote:
>> Should we commit this patch?
> To summarize:
> Robert Haas and Peter Eisentraut have done code-only reviews. Thomas
> Munro has reviewed and tested with a caveat that he is no BSD expert.
> Pierre-Emmanuel tested but did not do a code review review due to his
> unfamiliarity with the Postgres code-base.
> The patch does not seem invasive or likely to cause problems on non-BSD
> systems. From my perspective this has gotten about as much review as it
> can, so +1 from me at least.
Given our lack of BSD developers, there's probably not much more we can
do, but one more set of eyeballs on the patch wouldn't hurt. I'll take
it, unless somebody else wants to.
regards, tom lane
|Next Message||Andres Freund||2016-04-08 16:39:46||Re: Move PinBuffer and UnpinBuffer to atomics|
|Previous Message||Paul Ramsey||2016-04-08 16:27:37||Re: Choosing parallel_degree|