Re: syntax extension for unsupported JOINs coming from a binary only (unmodifyable) program

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Wolfgang <wh(at)ibas-labs(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: syntax extension for unsupported JOINs coming from a binary only (unmodifyable) program
Date: 2005-11-23 03:55:01
Message-ID: 10010.1132718101@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Wolfgang <wh(at)ibas-labs(dot)de> writes:
> Here are some little changes to the postgreSQL server backend I found
> beeing convenient for me

You don't seriously expect any of this to get applied, do you?

nullstr0 reverts a deliberate change made in PG 7.3. It's way past
time to be complaining about that.

LIKE_IS_ILIKE ... uh, well, no it isn't. If you'd like it to be, a
better approach would be to define a case-insensitive datatype (see
for example citext on pgfoundry) or a case-insensitive locale.

The proposed join change is, so far as I can see, a serious breakage of
the SQL spec. Perhaps you should fix the application to generate valid
SQL instead. (Even if it were a reasonable thing to do, postgres.c is
not a reasonable place to do it.)

More generally, it's been quite some time since we've looked with
favor on feature changes enabled by #ifdefs. Those aren't convenient
for anybody.

Lastly, diffs that are not -c or -u format will be rejected out of hand;
they are far too risky to apply to source code that is not exactly the
same version you started from.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-11-23 04:04:16 Re: [PATCHES] Should libedit be preferred to
Previous Message Joshua D. Drake 2005-11-23 03:36:27 Re: [PATCHES] Should libedit be preferred to