| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
| Cc: | Matthias van de Meent <boekewurm+postgres(at)gmail(dot)com>, Ilya Gladyshev <ilya(dot)v(dot)gladyshev(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Progress report of CREATE INDEX for nested partitioned tables |
| Date: | 2023-03-10 20:36:10 |
| Message-ID: | 1000008.1678480570@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Justin Pryzby <pryzby(at)telsasoft(dot)com> writes:
> Update to address a compiler warning in the supplementary patches adding
> assertions.
I took a look through this. It seems like basically a good solution,
but the count_leaf_partitions() function is bothering me, for two
reasons:
1. It seems like a pretty expensive thing to do. Don't we have the
info at hand somewhere already?
2. Is it really safe to do find_all_inheritors with NoLock? If so,
a comment explaining why would be good.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Regina Obe | 2023-03-10 20:38:25 | RE: Ability to reference other extensions by schema in extension scripts |
| Previous Message | Melanie Plageman | 2023-03-10 20:33:44 | Re: pg_stat_bgwriter.buffers_backend is pretty meaningless (and more?) |