Re: update substring pattern matching syntax

On 2020-06-20 09:08, Fabien COELHO wrote:
> I cannot say I'm a fan of this kind of keywords added for some arguments.
> I guess that it allows distinguishing between variants. I do not have the
> standard at hand: I wanted to check whether these keywords could be
> reordered, i.e. whether SUBSTRING(text ESCAPE ec SIMILAR part) was legal.
> I guess not.

It is not.

> Maybe the doc could advertise more systematically whether a features
> conforms fully or partially to some SQL standards, or is pg specific.

I think that would be useful, but it's probably a broader topic than
just for this specific function.

> The
> added documentation refers both to SQL:1999 and SQL99. I'd suggest to
> chose one, possibly the former, and use it everywhere consistently.

fixed

> It seems that two instances where not updated to the new syntax, see in
> ./src/backend/catalog/information_schema.sql and
> ./contrib/citext/sql/citext.sql.

done

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services