Re: psql: Count all table footer lines in pager setup

From: Erik Wienhold <ewie(at)ewie(dot)name>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Greg Sabino Mullane <htamfids(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: psql: Count all table footer lines in pager setup
Date: 2025-10-07 09:37:34
Message-ID: 0f586213-3cab-4ceb-9cb8-f1a5d4e6a708@ewie.name
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2025-10-07 00:45 +0200, Tom Lane wrote:
> I wrote:
> > Another inaccuracy that I find mildly annoying now that we've got it
> > mostly right is that we are not accounting for the blank line that
> > psql likes to print after the query result, so that you can still
> > end with the first output line scrolled off your screen despite
> > non-use of the pager. Not sure about a non-kluge way to count that,
> > though: it's outside the domain of print.c, and other callers might
> > not have a similar behavior.
>
> Oh wait! That line *is* produced within print.c, so there is no
> reason we shouldn't account for it. I spent a little extra effort
> on unaligned mode too, since the TAP test is checking that case.

LGTM.

> I still doubt that anyone's going to care a lot about the other
> formats.

Yup, I think so too.

--
Erik Wienhold

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Euler Taveira 2025-10-07 09:47:28 Re: oid2name : add objects file path
Previous Message Jingtang Zhang 2025-10-07 09:09:53 Re: Lock tag of relation extend lock