Re: [PATCH] postmaster: fix stale PM_STARTUP comment

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Ayush Tiwari <ayushtiwari(dot)slg01(at)gmail(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: [PATCH] postmaster: fix stale PM_STARTUP comment
Date: 2026-04-15 16:51:35
Message-ID: 0f462532-9790-4334-b503-4ee522225820@iki.fi
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 15/04/2026 16:57, Ayush Tiwari wrote:
> Hi,
>
> The comment above the PM_STARTUP startup-process-failure case still says
> that there are no other processes running yet, so the postmaster can just
> exit.
>
> That no longer matches the current startup flow: PM_STARTUP may already
> have auxiliary processes running by that point. The attached patch updates
> that comment to describe the current behavior.

Hmm, shouldn't the postmaster kill and wait for the auxiliary processes
to exit first in that case? ISTM we need code changes here, not just
comments.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2026-04-15 16:57:21 Re: First draft of PG 19 release notes
Previous Message Jacob Champion 2026-04-15 16:23:14 Re: Add errdetail() with PID and UID about source of termination signal