| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Magnus Hagander <magnus(at)hagander(dot)net>, Oskari Saarenmaa <os(at)ohmu(dot)fi>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Tobias Oberstein <tobias(dot)oberstein(at)gmail(dot)com> |
| Subject: | Re: pread() and pwrite() |
| Date: | 2018-11-07 15:05:02 |
| Message-ID: | 0f419c91-49ab-2399-0143-13063bd97c46@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Tom,
On 11/7/18 9:30 AM, Tom Lane wrote:
> I'm confused by this. Surely the pwrite-based code is writing exactly the
> same data as before. Do we have to conclude that valgrind is complaining
> about passing uninitialized data to pwrite() when it did not complain
> about exactly the same thing for write()?
>
> [ looks ... ] No, what we have to conclude is that the write-related
> suppressions in src/tools/valgrind.supp need to be replaced or augmented
> with pwrite-related ones.
>
The attached patch fixes this for me.
Unfortunately pwrite* doesn't work for the pwrite64(buf) line.
Best regards,
Jesper
| Attachment | Content-Type | Size |
|---|---|---|
| valgrind-supp.patch | text/x-patch | 306 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2018-11-07 15:26:01 | Re: [HACKERS] [PATCH] Generic type subscripting |
| Previous Message | Alvaro Herrera | 2018-11-07 15:04:27 | Re: move PartitionBoundInfo creation code |