From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
---|---|
To: | "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Tsunakawa, Takayuki" <tsunakawa(dot)takay(at)jp(dot)fujitsu(dot)com>, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: List of hostaddrs not supported |
Date: | 2017-06-09 09:52:02 |
Message-ID: | 0f3cade5-99c0-4744-9623-e3eb142e1ae7@iki.fi |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 06/08/2017 06:39 PM, David G. Johnston wrote:
> These are already failing so I'd agree that explicit rejection isn't
> necessary - the question seems restricted to usability. Though I suppose
> we need to consider whether there is any problem with the current setup if
> indeed our intended separator is also an allowable character - i.e., do we
> want to future-proof the syntax by requiring quotes now?
Hmm, there is one problem with our current use of comma as a separator:
you cannot use a Unix-domain socket directory that has a comma in the
name, because it's interpreted as multiple hostnames. E.g. this doesn't
work:
psql "host=/tmp/dir,with,commas"
For hostnames, ports, and network addresses (hostaddr), a comma is not a
problem, as it's not a valid character in any of those.
I don't know if that was considered when this patch was developed. I
couldn't find a mention of this in the archives. But in any case, that's
quite orthogonal to the rest of this thread.
- Heikki
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2017-06-09 10:06:57 | pgsql: Give a better error message on invalid hostaddr option. |
Previous Message | Michael Meskes | 2017-06-09 08:38:50 | Re: ECPG: WHENEVER statement with DO CONTINUE action |