Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman
Date: 2022-04-17 14:56:08
Message-ID: 0ec8e505-75ee-3426-78d9-9fd201c86f89@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers


On 2022-04-17 Su 00:17, Michael Paquier wrote:
>> Since it's quite painful to run TAP tests under valgrind, I found a
>> place to stick a plain old sleep to repro these problems:
> Actually, I am wondering how you are patching Cluster.pm to do that.

I don't really think it's Cluster.pm's business to deal with that. It
takes an install path as given either explicitly or implicitly.

It shouldn't be too hard to get Makefile.global to install valgrind
wrappers into the tmp_install/bin directory.

cheers

andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2022-04-17 23:49:17 Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman
Previous Message Michael Paquier 2022-04-17 04:17:32 Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2022-04-17 15:29:50 Re: Intermittent buildfarm failures on wrasse
Previous Message Andres Freund 2022-04-17 14:36:15 Re: Intermittent buildfarm failures on wrasse