Re: list of extended statistics on psql

From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
To: Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: list of extended statistics on psql
Date: 2021-01-12 11:08:30
Message-ID: 0e84aa72-25f2-1849-753f-f827949132b3@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers


On 1/12/21 2:57 AM, Tatsuro Yamada wrote:
> Hi Tomas,
>
> On 2021/01/09 9:01, Tomas Vondra wrote:
...>
>> While working on that, I realized that 'defined' might be a bit
>> ambiguous, I initially thought it means 'NOT NULL' (which it does not).
>> I propose to change it to 'requested' instead. Tatsuro, do you agree, or
>> do you think 'defined' is better?
>
> Regarding the status of extended stats, I think the followings:
>
>  - "defined": it shows the extended stats defined only. We can't know
>               whether it needs to analyze or not. I agree this name was
>                ambiguous. Therefore we should replace it with a more
> suitable
>               name.
>  - "requested": it shows the extended stats needs something. Of course,
>               we know it needs to ANALYZE because we can create the patch.
>               However, I feel there is a little ambiguity for DBA.
>               To solve this, it would be better to write an explanation of
>               the status in the document. For example,
>
> ======
> The column of the kind of extended stats (e. g. Ndistinct) shows some
> statuses.
> "requested" means that it needs to gather data by ANALYZE. "built" means
> ANALYZE
>  was finished, and the planner can use it. NULL means that it doesn't
> exists.
> ======
>
> What do you think? :-D
>

Yes, that seems reasonable to me. Will you provide an updated patch?

regards

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Li Japin 2021-01-12 11:17:12 Re: Logical Replication - behavior of ALTER PUBLICATION .. DROP TABLE and ALTER SUBSCRIPTION .. REFRESH PUBLICATION
Previous Message Masahiko Sawada 2021-01-12 10:43:24 Fix a typo in xlogreader.c