| From: | "Drouvot, Bertrand" <bertranddrouvot(dot)pg(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, reid(dot)thompson(at)crunchydata(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Patch to address creation of PgStat* contexts with null parent context |
| Date: | 2022-09-19 08:57:18 |
| Message-ID: | 0e364743-422b-91cc-192a-c5ef81908c52@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 9/17/22 6:10 PM, Andres Freund wrote:
> Hi,
>
> On 2022-09-07 11:11:11 +0200, Drouvot, Bertrand wrote:
>> On 9/6/22 7:53 AM, Kyotaro Horiguchi wrote:
>>> At Mon, 5 Sep 2022 14:46:55 +0200, "Drouvot, Bertrand"<bdrouvot(at)amazon(dot)com> wrote in
>>>> Looks like that both approaches have their pros and cons. I'm tempted
>>>> to vote +1 on "just changing" the parent context to TopMemoryContext
>>>> and not changing the allocations locations.
>>> Yeah. It is safe more than anything and we don't have a problem there.
>>>
>>> So, I'm fine with just replacing the parent context at the three places.
>>
>> Attached a patch proposal to do so.
>
> Pushed. Thanks for the report and the fix!
Thanks! I just marked the corresponding CF entry as Committed.
Regards,
--
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fujii Masao | 2022-09-19 09:08:51 | Re: Refactor backup related code (was: Is it correct to say, "invalid data in file \"%s\"", BACKUP_LABEL_FILE in do_pg_backup_stop?) |
| Previous Message | Aleksander Alekseev | 2022-09-19 08:57:09 | Re: Add common function ReplicationOriginName. |