Re: [PATCH] pgcrypto: Fix sha-crypt rounds= values that do not fit in int (BUG #19743)

Hi Prashant

On 2026/10/27 9:39, Prashant Chinnam wrote:

>
> I would prefer to keep clamping negative values in this patch.
> Clamping is the long-standing behaviour for values that fit in
> an int today -- rounds=-5 gives the below-minimum NOTICE and
> 1000 rounds on current master -- and this bug is specifically
> about the silent modulo 2^32 wrap of values that do not fit.
> Turning negative values into an ERROR would change behaviour
> for inputs that currently work, and it would be hard to
> backpatch, while the wrap fix itself should be backpatchable
> to REL_18_STABLE. If negative rounds should error, I think
> that deserves its own discussion and a master-only change.
> What do you think?

Sure. Thank you for pointing this out. As you said, how to handle
negative value is a bit different topic from the main issue here. Let's
keep the current behavior in this thread unless another concern arise.

Regards,
Takeshi Ideriha