| From: | Mircea Cadariu <cadariu(dot)mircea(at)gmail(dot)com> |
|---|---|
| To: | Anthonin Bonnefoy <anthonin(dot)bonnefoy(at)datadoghq(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Propagate XLogFindNextRecord error to callers |
| Date: | 2026-02-03 16:05:40 |
| Message-ID: | 0cbf5d34-f117-456f-bcc0-50fa9a8eafba@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Anthonin,
On 12/12/2025 10:39, Anthonin Bonnefoy wrote:
>
> With this patch, pg_waldump will now have the following output when
> reading a file with an invalid header:
> pg_waldump: error: could not find a valid record after D80/5C000000:
> invalid magic number D116 in WAL segment 0000001400000D8000000017, LSN
> D80/5C000000, offset 0
I've picked up the review for your patch.
Attached is a failing test that reproduces the issue. Have I got it
right? We can consider using it to validate your patch then.
--
Thanks,
Mircea Cadariu
| Attachment | Content-Type | Size |
|---|---|---|
| v1-0001-Add-pg_waldump-test-for-invalid-WAL-page-magic-er.patch | text/plain | 1.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2026-02-03 16:26:56 | Odd code around ginScanToDelete |
| Previous Message | Srirama Kucherlapati | 2026-02-03 16:03:37 | RE: AIX support |