Re: refactoring basebackup.c

From: tushar <tushar(dot)ahuja(at)enterprisedb(dot)com>
To: Dilip Kumar <dilipbalaut(at)gmail(dot)com>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Mark Dilger <mark(dot)dilger(at)enterprisedb(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: refactoring basebackup.c
Date: 2021-07-22 17:14:31
Message-ID: 0caaf88d-18c0-943a-d7ab-ac0fd5b05dc3@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 7/19/21 8:29 PM, Dilip Kumar wrote:
> I am not sure why this is working, from the code I could not find if
> the backup target is server then are we doing anything with the -R
> option or we are just silently ignoring it

OK, in an  another scenario  I can see , "-t server" working with
"--server-compression" option  but not with -z  or -Z ?

"-t  server" with option "-z"  / or (-Z )

[tushar(at)localhost bin]$ ./pg_basebackup -t server:/tmp/dataN -Xnone  -z 
--no-manifest -p 9033
pg_basebackup: error: only tar mode backups can be compressed
Try "pg_basebackup --help" for more information.

tushar(at)localhost bin]$ ./pg_basebackup -t server:/tmp/dataNa -Z 1   
-Xnone  --server-compression=gzip4  --no-manifest -p 9033
pg_basebackup: error: only tar mode backups can be compressed
Try "pg_basebackup --help" for more information.

"-t server" with "server-compression"  (working)

[tushar(at)localhost bin]$ ./pg_basebackup -t server:/tmp/dataN -Xnone 
--server-compression=gzip4  --no-manifest -p 9033
NOTICE:  WAL archiving is not enabled; you must ensure that all required
WAL segments are copied through other means to complete the backup
[tushar(at)localhost bin]$

--
regards,tushar
EnterpriseDB https://www.enterprisedb.com/
The Enterprise PostgreSQL Company

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Arne Roland 2021-07-22 17:22:57 Re: Rename of triggers for partitioned tables
Previous Message Peter Volk 2021-07-22 16:36:41 Re: Followup Timestamp to timestamp with TZ conversion