| From: | David Steele <david(at)pgmasters(dot)net> |
|---|---|
| To: | Stephen Frost <sfrost(at)snowman(dot)net>, Teodor Sigaev <teodor(at)sigaev(dot)ru> |
| Cc: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Adam Brightwell <adam(dot)brightwell(at)crunchydata(dot)com>, Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> |
| Subject: | Re: PATCH: Exclude temp relations from base backup |
| Date: | 2018-03-26 17:08:50 |
| Message-ID: | 0c578293-6757-0204-b897-528492efd836@pgmasters.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 3/26/18 1:06 PM, Stephen Frost wrote:
>
> * Teodor Sigaev (teodor(at)sigaev(dot)ru) wrote:
>> Will autovacuum (or something else) complain about absense of relfile during
>> orphan table deleting? I mean, you get a base backup without temp tables,
>> then you try to run postgres on it and will it complain about existing
>> record in pg_class and absence of corresponding relfile?
>
> I would certainly hope not considering that's what happens during
> regular crash recovery also, so if there's an issue with that, we'd have
> a problem in released versions.
Agreed. The logic for pg_basebackup was modeled off RemovePgTempFiles()
which is called at postmaster start. We are just doing the cleanup in
advance (in the backup only, of course).
Thanks,
--
-David
david(at)pgmasters(dot)net
| From | Date | Subject | |
|---|---|---|---|
| Next Message | John Naylor | 2018-03-26 17:35:37 | Re: WIP: a way forward on bootstrap data |
| Previous Message | Stephen Frost | 2018-03-26 17:06:19 | Re: PATCH: Exclude temp relations from base backup |