| From: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: make update-po@master stops at pg_upgrade |
| Date: | 2022-07-13 18:09:15 |
| Message-ID: | 0c34f1ca-71e7-f6e7-7d59-5294f995c78b@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 13.07.22 18:07, Tom Lane wrote:
> Still, wildcarding the local *.c references seems like a clear step
> forward. I'll go push that part.
In some cases, the listed files are build output from another rule, for
example sql_help.c. By using a wildcard, you just take whatever files
happen to be there, not observing proper make dependencies.
(Conversely, you could also include files that are not part of the
build, maybe leftover from something aborted.) So I'm not sure this is
such a clear win. In any case, someone should check that this creates
identical output before and after.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2022-07-13 18:19:40 | Re: make update-po@master stops at pg_upgrade |
| Previous Message | Robert Haas | 2022-07-13 17:50:39 | Re: strings: ".. (compression)? is not supported by this build" |